Updated CONTRIBUTING.md 2.7.f #6974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Want to review this pull request? Take a look at this documentation for a step by step guide! Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL: |
github-actions
bot
added
role: front end
|
Review ETA: End of today |
t-will-gillis
requested changes
Jun 10, 2024
There was a problem hiding this comment.
@andyphancode Great job!
- branches look good
- original issue is linked
- there is a concise description of what changes were made and why
- there are visuals for the changes, (which might not be needed, but no harm in this case!)
Everything looks great, however, I have a couple minor requests:
- Would you please remove the extra ticks in "What changes did you make?" and "Why did you make the changes"
- This is outside of the scope of this issue, but if you agree I feel like
git bashshould be capitalized for consistency, on the line that beginsIMPORTANT: ...
Thanks for working on this
t-will-gillis
requested changes
Jun 11, 2024
No disagreement, just believed it was outside the scope of the issue #. Agreed it should be changed. @t-will-gillis |
t-will-gillis
approved these changes
Jun 12, 2024
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6185
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied